Detect reorgs during event processing #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the hash of the retrieved L1 block against the block hash in the event log we processed. This will detect if the block has changed (due to a reorg) in the time since we processed it. In this case we simply return an error so that the synchronizer will retry fetching the events, now with the new L1 state. If we don't check this here, we might never detect this reorg, because we will store the hash of the retrieved block (from after the reorg) even though we processed events from the block which got reorged out. The stored hash will then match the hash when we query it again from the L1 in checkReorg, and we will never process events from the new block.
|
After restarting the node, it successfully synced past the problematic block. This is consistent with the problem being caused by a reorg the first time around. |
nomaxg
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the hash of the retrieved L1 block against the block hash in the event log we processed. This will detect if the block has changed (due to a reorg) in the time since we processed it. In this case we simply return an error so that the synchronizer will retry fetching the events, now with the new L1 state.
If we don't check this here, we might never detect this reorg, because we will store the hash of the retrieved block (from after the reorg) even though we processed events from the block which got reorged out. The stored hash will then match the hash when we query it again from the L1 in checkReorg, and we will never process events from the new block.
Potential fix for EspressoSystems/espresso-polygon-zkevm-demo#252.